Bug 133022

Summary: Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, bunhere, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jamesr, kondapallykalyan, luiz, rakuco, sergio, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172349    
Attachments:
Description Flags
Patch
none
EWS for EFL none

Description Simon Fraser (smfr) 2014-05-16 18:42:07 PDT
Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
Comment 1 Simon Fraser (smfr) 2014-05-16 18:49:07 PDT
Created attachment 231612 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-16 18:50:28 PDT
Attachment 231612 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:167:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:175:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-05-19 11:06:25 PDT
Created attachment 231703 [details]
EWS for EFL
Comment 4 WebKit Commit Bot 2014-05-19 11:09:40 PDT
Attachment 231703 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:167:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:175:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2014-05-19 13:42:35 PDT
http://trac.webkit.org/changeset/169063
Comment 6 Andreas Kling 2014-05-19 14:04:53 PDT
Comment on attachment 231703 [details]
EWS for EFL

Removing from review queue since this already landed.