Bug 133007

Summary:

REGRESSION (NetworkProcess): Trying to use appcache fallback crashes in ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Page Loading

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, darin, japhet, jonlee

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	mjs: review+
patch for landing	none

Description Alexey Proskuryakov 2014-05-16 14:04:58 PDT

Steps to reproduce:

run-webkit-tests -2 http/tests/appcache/fallback.html

<rdar://problem/13702706>

Comment 1 Alexey Proskuryakov 2014-05-16 16:02:19 PDT

Created attachment 231601 [details]
proposed fix

Comment 2 WebKit Commit Bot 2014-05-16 16:03:52 PDT

Attachment 231601 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Maciej Stachowiak 2014-05-17 20:42:57 PDT

Comment on attachment 231601 [details]
proposed fix

r=me
Please fix the style bot's whitespace complaint: WebCore.exp.in:Export

Comment 4 Alexey Proskuryakov 2014-05-17 21:52:22 PDT

Created attachment 231646 [details]
patch for landing

Comment 5 WebKit Commit Bot 2014-05-17 22:30:06 PDT

Comment on attachment 231646 [details]
patch for landing

Clearing flags on attachment: 231646

Committed r169006: <http://trac.webkit.org/changeset/169006>

Comment 6 WebKit Commit Bot 2014-05-17 22:30:09 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Jon Lee 2014-05-18 09:54:22 PDT

Committed build fix: http://trac.webkit.org/changeset/169013