Bug 132976

Summary:

[Mac] Move discovery of sharing services off the main thread

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

WebKit Misc.

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	beidson: review+, beidson: commit-queue-

Description Mark Rowe (bdash) 2014-05-15 16:56:19 PDT

Discovering sharing services isn't a particularly cheap operation, requiring disk access and even IPC. Since the discovery is already asynchronous and we've been told the API we're using can be safely used from a background thread, we should move it off the main thread.

Comment 1 Mark Rowe (bdash) 2014-05-15 17:01:22 PDT

Created attachment 231543 [details]
Patch

Comment 2 Brady Eidson 2014-05-15 17:08:21 PDT

Comment on attachment 231543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231543&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:82
> +    NSLog(@"+ServicesController::refreshExistingServices");

No.

> Source/WebKit2/UIProcess/mac/ServicesController.mm:110
> +            NSLog(@"-ServicesController::refreshExistingServices");

No.

Comment 3 Mark Rowe (bdash) 2014-05-15 17:15:55 PDT

Landed in <http://trac.webkit.org/changeset/168918>.