Bug 132973

Summary: [MSE] Crash at WebCore::SourceBuffer::~SourceBuffer + 110
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Jer Noble 2014-05-15 16:03:41 PDT 
[MSE] Crash at  WebCore::SourceBuffer::~SourceBuffer + 110
Comment 1 Jer Noble 2014-05-15 16:15:07 PDT 
Created attachment 231539 [details]
Patch
Comment 2 Jer Noble 2014-05-15 16:15:45 PDT 
Created attachment 231540 [details]
Patch
Comment 3 Jer Noble 2014-05-15 22:03:06 PDT 
Created attachment 231557 [details]
Patch
Comment 4 Jer Noble 2014-05-16 09:47:52 PDT 
Created attachment 231578 [details]
Patch
Comment 5 Jer Noble 2014-05-16 10:29:49 PDT 
Created attachment 231579 [details]
Patch
Comment 6 Eric Carlson 2014-05-16 11:45:02 PDT 
Comment on attachment 231579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231579&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:529
> +        [parser appendStreamData:nsData.get()];

Nit: is there any reason to append the data if weakThis is already NULL?
Comment 7 Jer Noble 2014-05-16 12:15:25 PDT 
Comment on attachment 231579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231579&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:529
>> +        [parser appendStreamData:nsData.get()];
> 
> Nit: is there any reason to append the data if weakThis is already NULL?

We can't call WeakPtr.get() off the main thread, due to the way WeakPtrs work.  So there's no way to check within this part of the call.
Comment 8 WebKit Commit Bot 2014-05-16 12:45:45 PDT 
Comment on attachment 231579 [details]
Patch

Clearing flags on attachment: 231579

Committed r168974: <http://trac.webkit.org/changeset/168974>
Comment 9 WebKit Commit Bot 2014-05-16 12:45:50 PDT 
All reviewed patches have been landed.  Closing bug.