| Summary: | [GTK][EFL] Video is resumed with old playback rate. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Piotr Grad <piotr.grad> | ||||||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | agomez, calvaris, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, philipj, pnormand, sergio, vjaquez | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Piotr Grad
2014-05-14 06:59:02 PDT
Created attachment 231447 [details]
Patch & layout test
Attachment 231447 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:410: Missing space before ( in if( [whitespace/parens] [5]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:565: Missing space before ( in if( [whitespace/parens] [5]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:623: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 231449 [details]
Patch & layout test
Attachment 231449 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:565: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 231451 [details]
Patch & layout test
Comment on attachment 231451 [details] Patch & layout test View in context: https://bugs.webkit.org/attachment.cgi?id=231451&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:568 > + if (!rate) { > + return gst_element_seek(m_playBin.get(), 1.0, GST_FORMAT_TIME, seekType, > + GST_SEEK_TYPE_SET, startTime, GST_SEEK_TYPE_SET, endTime); > + } Perhaps this could be if(!rate) rate = 1.0 ? Created attachment 231840 [details]
Patch & layout test
Comment on attachment 231840 [details] Patch & layout test Clearing flags on attachment: 231840 Committed r169200: <http://trac.webkit.org/changeset/169200> All reviewed patches have been landed. Closing bug. |