Bug 132885

Summary:

[Mac] hasVideo should return true when video is ready to display

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

ASSIGNED ---

Severity:

Normal

CC:

calvaris, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
wrong file...	none

Description Eric Carlson 2014-05-13 14:52:15 PDT

If the AVPlayerLayer is readyForDisplay, set hasVideo to true.

Comment 1 Eric Carlson 2014-05-13 15:04:59 PDT

Created attachment 231409 [details]
Proposed patch

Comment 2 WebKit Commit Bot 2014-05-13 15:06:12 PDT

Attachment 231409 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Jer Noble 2014-05-13 16:18:25 PDT

Comment on attachment 231409 [details]
Proposed patch

r=me

Comment 4 Eric Carlson 2014-05-13 16:37:54 PDT

Created attachment 231419 [details]
wrong file...

Comment 5 Eric Carlson 2014-05-13 16:49:47 PDT

Committed r168755: http://trac.webkit.org/changeset/168755

Comment 6 Eric Carlson 2014-05-13 17:01:46 PDT

Plus a build fix landed in r168758: http://trac.webkit.org/changeset/168758