Summary: | REGRESSION(r168642): Broke ARM build (Requested by jpfau on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||
Component: | New Bugs | Assignee: | WebKit Commit Bot <commit-queue> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, jeffrey+webkit, peavo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 132772 | ||||||
Attachments: |
|
Description
WebKit Commit Bot
2014-05-12 15:12:17 PDT
Created attachment 231331 [details] ROLLOUT of r168642 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 231331 [details] ROLLOUT of r168642 The patch broke the build on ARM, e.g.: Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:954:9: error: no matching member function for call to 'loadDouble' loadDouble(address.m_ptr, fpTempRegister); Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:1159:9: error: no matching member function for call to 'loadDouble' loadDouble(address.m_ptr, fpTempRegister); Please try to fix it and have someone who can test the ARM build check it before re-landing. Comment on attachment 231331 [details] ROLLOUT of r168642 Clearing flags on attachment: 231331 Committed r168649: <http://trac.webkit.org/changeset/168649> All reviewed patches have been landed. Closing bug. |