Bug 132771

Summary: [EFL][WK2] Move the ownership of EwkSettings from EwkView to EwkPageGroup
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2014-05-09 23:59:29 PDT
EwkSettings specialized WKPreferences which WKPageGroup contains. So, we'd better to move ownership of EwkSettings.
Attachments
Patch (6.12 KB, patch)
2014-05-10 00:01 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-05-10 00:01:49 PDT
Created attachment 231219 [details] Patch
Gyuyoung Kim
Comment 2 2014-05-10 00:04:28 PDT
Comment on attachment 231219 [details] Patch I agree with this moving.
WebKit Commit Bot
Comment 3 2014-05-10 18:35:37 PDT
Comment on attachment 231219 [details] Patch Clearing flags on attachment: 231219 Committed r168590: <http://trac.webkit.org/changeset/168590>
WebKit Commit Bot
Comment 4 2014-05-10 18:35:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.