Bug 132766

Summary: Subpixel (?) errors in high-dpi filters tests
Product: WebKit Reporter: Dean Jackson <dino>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW ---    
Severity: Normal CC: ap, jonlee, mmaxfield, sabouhallawa, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232384
Bug Depends on: 93471    
Bug Blocks:    
Attachments:
Description Flags
Patch sam: review+

Description Dean Jackson 2014-05-09 19:43:04 PDT 
https://bugs.webkit.org/show_bug.cgi?id=93471 is adding some new tests that fail with very small image differences on Mac WK2. It looks like the anti-aliasing is slightly wrong on the edge of the text object. Could this be subpixel?
Comment 1 Radar WebKit Bug Importer 2014-05-09 19:52:39 PDT 
<rdar://problem/16875024>
Comment 2 zalan 2014-05-09 20:50:16 PDT 
(In reply to comment #0)
> https://bugs.webkit.org/show_bug.cgi?id=93471 is adding some new tests that fail with very small image differences on Mac WK2. It looks like the anti-aliasing is slightly wrong on the edge of the text object. Could this be subpixel?

Yes it could, though if you wanna do hiDPI test, you should prefix it with hidpi- instead (see http://trac.webkit.org/changeset/165470). It automatically turns DumpRenderTree/WebKitTestRunner into hidpi mode and runs the test (not sure what the ensure-hidpi.js does or if it works properly at all)
Comment 3 Dean Jackson 2014-05-10 02:40:41 PDT 
Ooh, you told me this already - I forgot, sorry :(

I'll fix the test names.
Comment 4 zalan 2014-05-10 07:25:35 PDT 
(In reply to comment #3)
> Ooh, you told me this already - I forgot, sorry :(
> 
> I'll fix the test names.
I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775
Comment 5 Radar WebKit Bug Importer 2014-07-21 11:01:30 PDT 
<rdar://problem/17749324>
Comment 6 Alexey Proskuryakov 2014-07-21 11:01:39 PDT 
<rdar://problem/17749328>
Comment 7 Simon Fraser (smfr) 2021-12-21 20:55:30 PST 
Created attachment 447778 [details]
Patch
Comment 8 Sam Weinig 2021-12-29 08:44:36 PST 
(In reply to zalan from comment #4)
> (In reply to comment #3)
> > Ooh, you told me this already - I forgot, sorry :(
> > 
> > I'll fix the test names.
> I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775

Where do we stand with this comment?
Comment 9 zalan 2021-12-29 08:56:04 PST 
(In reply to Sam Weinig from comment #8)
> (In reply to zalan from comment #4)
> > (In reply to comment #3)
> > > Ooh, you told me this already - I forgot, sorry :(
> > > 
> > > I'll fix the test names.
> > I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775
> 
> Where do we stand with this comment?
I don't think I am going to be working on it anytime soon; not sure about if others have plans.