Bug 132764

Summary:

Web Inspector: timeline overview should visually distinguish selection bounds outside the visible duration

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none
[Video] New UI & behavior	none
[Patch] Proposed Fix	none

Description Brian Burg 2014-05-09 18:56:47 PDT

If you zoom the overview such that the selection start time is before the visible start time, the selection marker is clamped to the left. But, the marker doesn't change styles, so it's hard to tell if the selection duration was clamped to the visible start time (false) or is just visually clipped (true).

We could make the selection markers translucent if they represent a non-visible selection start time, or replace/supplement them with little arrows/chevrons to to indicate that the marker is not positioned at the actual edge of the selection.

Comment 1 Radar WebKit Bug Importer 2014-05-09 18:57:12 PDT

<rdar://problem/16874806>

Comment 2 Matt Baker 2015-08-02 02:43:33 PDT

Created attachment 258035 [details]
[Patch] Proposed Fix

Comment 3 Matt Baker 2015-08-02 03:20:07 PDT

Created attachment 258036 [details]
[Patch] Proposed Fix

Comment 4 Matt Baker 2015-08-03 15:35:44 PDT

Created attachment 258126 [details]
[Video] New UI & behavior

Comment 5 BJ Burg 2015-08-04 13:19:47 PDT

Comment on attachment 258036 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=258036&action=review

r=me

> Source/WebInspectorUI/ChangeLog:13
> +        Toogle style class and add tool tip showing the handle's value when outside the visible range.

Toogle -> Toggle

Comment 6 Matt Baker 2015-08-04 13:35:34 PDT

Created attachment 258205 [details]
[Patch] Proposed Fix

Comment 7 WebKit Commit Bot 2015-08-04 13:49:48 PDT

Comment on attachment 258205 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258205

Committed r187887: <http://trac.webkit.org/changeset/187887>

Comment 8 WebKit Commit Bot 2015-08-04 13:49:51 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Timothy Hatcher 2015-08-04 15:34:08 PDT

Neat!