Bug 132758

Summary: [fullscreen] cursor should auto-hide when over video
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, joepeck, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch bfulgham: review+

Description Dean Jackson 2014-05-09 16:46:04 PDT
[fullscreen] cursor should auto-hide when over video
Comment 1 Dean Jackson 2014-05-09 16:48:48 PDT
Created attachment 231196 [details]
Comment 2 Joseph Pecoraro 2014-05-09 16:59:18 PDT
Perhaps this is just me, but I would expect controls to auto-hide everywhere. Inline video, fullscreen video, fullscreen page (e.g. <body>) with an inline video, everything.
Comment 3 Dean Jackson 2014-05-09 17:02:42 PDT
Comment on attachment 231196 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=231196&action=review

> Source/WebCore/css/fullscreen.css:36
>      -webkit-cursor-visibility:auto-hide;

I will add a space.
Comment 4 Brent Fulgham 2014-05-09 17:36:24 PDT
Comment on attachment 231196 [details]

Comment 5 Dean Jackson 2014-05-09 17:39:21 PDT
Committed r168561: <http://trac.webkit.org/changeset/168561>
Comment 6 Dean Jackson 2014-05-09 17:39:30 PDT
Comment 7 Alexey Proskuryakov 2014-05-09 18:28:02 PDT
The new test fail on all bots that caught up to this revision:

Comment 8 Dean Jackson 2014-05-09 18:57:48 PDT
Strange that it doesn't reproduce locally (WK1 Mav)

Also strange that the actual effect was broken (hence the bug) and the test didn't pick it up (which is why I didn't add a new test).
Comment 9 Dean Jackson 2014-05-09 18:58:02 PDT
Anyway, investigating.
Comment 10 Dean Jackson 2014-05-09 19:21:34 PDT
Hopefully fixed in r168570
Comment 11 Alexey Proskuryakov 2014-05-10 17:00:45 PDT
Looks fixed, thanks!

> which is why I didn't add a new test

Not sure why I decided that it was new - probably because its name was such a close match for this bug's title :)