Summary: | [fullscreen] cursor should auto-hide when over video | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, joepeck, macpherson, menard | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2014-05-09 16:46:04 PDT
Created attachment 231196 [details]
Patch
Perhaps this is just me, but I would expect controls to auto-hide everywhere. Inline video, fullscreen video, fullscreen page (e.g. <body>) with an inline video, everything. Comment on attachment 231196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231196&action=review > Source/WebCore/css/fullscreen.css:36 > -webkit-cursor-visibility:auto-hide; I will add a space. Comment on attachment 231196 [details]
Patch
r=me
Committed r168561: <http://trac.webkit.org/changeset/168561> The new test fail on all bots that caught up to this revision: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r168561%20(5906)/fullscreen/video-cursor-auto-hide-diff.txt Strange that it doesn't reproduce locally (WK1 Mav) Also strange that the actual effect was broken (hence the bug) and the test didn't pick it up (which is why I didn't add a new test). Anyway, investigating. Hopefully fixed in r168570 Looks fixed, thanks!
> which is why I didn't add a new test
Not sure why I decided that it was new - probably because its name was such a close match for this bug's title :)
|