Bug 132758

Summary: [fullscreen] cursor should auto-hide when over video
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, joepeck, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Dean Jackson
Reported 2014-05-09 16:46:04 PDT
[fullscreen] cursor should auto-hide when over video
Attachments
Patch (1.46 KB, patch)
2014-05-09 16:48 PDT, Dean Jackson 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-05-09 16:48:48 PDT
Created attachment 231196 [details] Patch
Joseph Pecoraro
Comment 2 2014-05-09 16:59:18 PDT
Perhaps this is just me, but I would expect controls to auto-hide everywhere. Inline video, fullscreen video, fullscreen page (e.g. <body>) with an inline video, everything.
Dean Jackson
Comment 3 2014-05-09 17:02:42 PDT
Comment on attachment 231196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231196&action=review > Source/WebCore/css/fullscreen.css:36 > -webkit-cursor-visibility:auto-hide; I will add a space.
Brent Fulgham
Comment 4 2014-05-09 17:36:24 PDT
Comment on attachment 231196 [details] Patch r=me
Dean Jackson
Comment 5 2014-05-09 17:39:21 PDT
Committed r168561: <http://trac.webkit.org/changeset/168561>
Dean Jackson
Comment 6 2014-05-09 17:39:30 PDT
<rdar://problem/16690379>
Alexey Proskuryakov
Comment 7 2014-05-09 18:28:02 PDT
The new test fail on all bots that caught up to this revision: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r168561%20(5906)/fullscreen/video-cursor-auto-hide-diff.txt
Dean Jackson
Comment 8 2014-05-09 18:57:48 PDT
Strange that it doesn't reproduce locally (WK1 Mav) Also strange that the actual effect was broken (hence the bug) and the test didn't pick it up (which is why I didn't add a new test).
Dean Jackson
Comment 9 2014-05-09 18:58:02 PDT
Anyway, investigating.
Dean Jackson
Comment 10 2014-05-09 19:21:34 PDT
Hopefully fixed in r168570
Alexey Proskuryakov
Comment 11 2014-05-10 17:00:45 PDT
Looks fixed, thanks! > which is why I didn't add a new test Not sure why I decided that it was new - probably because its name was such a close match for this bug's title :)
Note You need to log in before you can comment on or make changes to this bug.