Bug 132739

Summary: REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 132686    
Bug Blocks:    
Attachments:
Description Flags
Patch
andersca: review+
Patch for landing
none
Patch for landing none

Carlos Garcia Campos
Reported 2014-05-09 05:55:59 PDT
We lost these ones too with the switch to CMAKE
Attachments
Patch (3.03 KB, patch)
2014-05-09 06:35 PDT, Carlos Garcia Campos 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (32.31 KB, patch)
2014-05-11 00:11 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.41 KB, patch)
2014-05-11 00:12 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-05-09 06:35:47 PDT
Created attachment 231151 [details] Patch
Martin Robinson
Comment 2 2014-05-09 09:29:12 PDT
Comment on attachment 231151 [details] Patch These test are platform independent right? Perhaps they should go into the shared CMakeLists.txt file like the other shared tests?
Carlos Garcia Campos
Comment 3 2014-05-11 00:10:41 PDT
(In reply to comment #2) > (From update of attachment 231151 [details]) > These test are platform independent right? Perhaps they should go into the shared CMakeLists.txt file like the other shared tests? You are right!
Carlos Garcia Campos
Comment 4 2014-05-11 00:11:10 PDT
Created attachment 231255 [details] Patch for landing
Carlos Garcia Campos
Comment 5 2014-05-11 00:12:52 PDT
Created attachment 231256 [details] Patch for landing Oops submitted the wrong patch, sorry.
WebKit Commit Bot
Comment 6 2014-05-11 00:15:52 PDT
Attachment 231256 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/CMakeLists.txt:18: Alphabetical sorting problem. "JavaScriptCore" should be before "WTF". [list/order] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 7 2014-05-12 01:58:34 PDT
Committed r168615: <http://trac.webkit.org/changeset/168615>
Note You need to log in before you can comment on or make changes to this bug.