Summary: | REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, sergio | ||||||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 132686 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-05-09 05:55:59 PDT
Created attachment 231151 [details]
Patch
Comment on attachment 231151 [details]
Patch
These test are platform independent right? Perhaps they should go into the shared CMakeLists.txt file like the other shared tests?
(In reply to comment #2) > (From update of attachment 231151 [details]) > These test are platform independent right? Perhaps they should go into the shared CMakeLists.txt file like the other shared tests? You are right! Created attachment 231255 [details]
Patch for landing
Created attachment 231256 [details]
Patch for landing
Oops submitted the wrong patch, sorry.
Attachment 231256 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/CMakeLists.txt:18: Alphabetical sorting problem. "JavaScriptCore" should be before "WTF". [list/order] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r168615: <http://trac.webkit.org/changeset/168615> |