Summary: | [CSS Blending] Adjust blending pixel test expectations | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ion Rosca <rosca> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, WebkitBugTracker | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Ion Rosca
2014-05-09 05:09:28 PDT
Created attachment 231145 [details]
Patch
Created attachment 231147 [details]
Patch
Attachment 231147 [details] did not pass style-queue:
ERROR: LayoutTests/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:24: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:25: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:26: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:44: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:45: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:46: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: LayoutTests/ChangeLog:47: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 11 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 231149 [details]
Patch
Comment on attachment 231149 [details]
Patch
r=me
Comment on attachment 231149 [details] Patch Rejecting attachment 231149 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 231149, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ode-image-color-dynamic-expected.html (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file LayoutTests/platform/mac-wk1/TestExpectations patching file LayoutTests/platform/mac/TestExpectations patching file LayoutTests/platform/mac/css3/blending/blend-mode-overflow-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Mihnea Ovidenie']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5306088312274944 Created attachment 231278 [details]
Patch
Comment on attachment 231278 [details] Patch Clearing flags on attachment: 231278 Committed r168616: <http://trac.webkit.org/changeset/168616> All reviewed patches have been landed. Closing bug. |