Summary: | REGRESSION (r168053): Phone number detection boxes are wrong when scrolled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, beidson, simon.fraser, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2014-05-08 14:31:29 PDT
Created attachment 231101 [details]
Patch
Thanks Tim! http://trac.webkit.org/changeset/168499 Comment on attachment 231101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231101&action=review > Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:66 > + size_t size = textQuads.size(); > + for (size_t i = 0; i < size; ++i) > + boundingRect.unite(textQuads[i].boundingBox()); Should use a modern for loop: for (auto& quad : textQuads) boundingRect.unit(quad.boundingBox()); |