Bug 132697

Summary:

Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode should gracefully handle bad node

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, jcraig, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-05-08 11:57:43 PDT

Saw the following: ASSERTION FAILED: node Source/WebCore/inspector/InspectorDOMAgent.cpp(1435) : PassRefPtr<TypeBuilder::DOM::AccessibilityProperties> WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties(WebCore::Node *) 1 0x1030b4c00 WTFCrash 2 0x104f83a21 WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties(WebCore::Node*) 3 0x104f8399b WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode(WTF::String*, int, WTF::RefPtr<Inspector::TypeBuilder::DOM::AccessibilityProperties>&) 4 0x104f84cdd non-virtual thunk to WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode(WTF::String*, int, WTF::RefPtr<Inspector::TypeBuilder::DOM::AccessibilityProperties>&) 5 0x1050338e8 Inspector::InspectorDOMBackendDispatcher::getAccessibilityPropertiesForNode(long, Inspector::InspectorObject const&) 6 0x105030fb6 Inspector::InspectorDOMBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) 7 0x102ce205c Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) 8 0x104f44661 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 9 0x105928a09 WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend(WTF::String const&) 10 0x102fff326 invocation function for block in Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend(NSString*) 11 0x103000624 Inspector::RemoteInspectorBlock::operator()() const 12 0x102fff895 Inspector::RemoteInspectorHandleRunSource(void*) 13 0x7fff910b34f1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 14 0x7fff910a4d4d __CFRunLoopDoSources0 15 0x7fff910a44eb __CFRunLoopRun 16 0x7fff910a3d88 CFRunLoopRunSpecific 17 0x7fff8ece8125 RunCurrentEventLoopInMode 18 0x7fff8ece7eae ReceiveNextEventCommon 19 0x7fff8ece7cee _BlockUntilNextEventMatchingListInModeWithFilter 20 0x7fff90257bc0 _DPSNextEvent 21 0x7fff902573c4 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 22 0x7fff9024b241 -[NSApplication run] 23 0x7fff90236cb7 NSApplicationMain 24 0x1000013b2 main 25 0x7fff923ad5c9 start

Attachments
[PATCH] Proposed Fix (1.39 KB, patch) 2014-05-08 12:00 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-05-08 11:58:22 PDT

<rdar://problem/16856404>

Joseph Pecoraro

Comment 2 2014-05-08 12:00:42 PDT

Created attachment 231087 [details] [PATCH] Proposed Fix In release builds buildObjectForAccessibilityProperties would return nullptr. In debug builds we would assert if we passed a null node to buildObjectForAccessibilityProperties. So more gracefully handle a null node before calling the function.

WebKit Commit Bot

Comment 3 2014-05-08 14:20:40 PDT

Comment on attachment 231087 [details] [PATCH] Proposed Fix Clearing flags on attachment: 231087 Committed r168495: <http://trac.webkit.org/changeset/168495>

WebKit Commit Bot

Comment 4 2014-05-08 14:20:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.