Bug 132681 – [GTK] Use a different user agent string depending on the site

• Component: Platform
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We have changed the user agent string several times to try to fix broken websites that require specific things in the UA string to properly work. But everytime we change the UA string to fix and website we break others. So, we could use different UA string depending on the web site when the site specific quirks setting is enabled. We used to do this in WebKit1, but it was never ported to WebKit2.

[Carlos Garcia Campos]

Created attachment 231063 [details]
Patch

I have converted the latest changes to the user agent as site specific quirks

[Carlos Garcia Campos]

Created attachment 231068 [details]
Try to fix mac build

[Gustavo Noronha (kov)]

Comment on attachment 231068 [details]
Try to fix mac build

LGTM, I think we'll want to add the google bits from before to stop getting the second-class pages for google, but I really like how you structured it. I guess we need a wk2 owner to stamp it though?

[Carlos Garcia Campos]

Adding wk2 owners to the CC.

[Sergio Villar Senin]

Comment on attachment 231068 [details]
Try to fix mac build

View in context: https://bugs.webkit.org/attachment.cgi?id=231068&action=review

I like the patch. My only concern is having to add new broken sites to the code as we find them, but I guess we've lost the race for the works-for-all-sites UA many times.

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:146
> +        uaString.appendLiteral(" Version/6.0");

Some users reported that some sites where complaining about using an old Safari version. Should we use 7.0 (or the most recent one)?

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:189
> +    }

We used to have rules also for google domains in WK1. Time to resurrect them?

[Carlos Garcia Campos]

(In reply to comment #5)
> (From update of attachment 231068 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231068&action=review
> 
> I like the patch. My only concern is having to add new broken sites to the code as we find them, but I guess we've lost the race for the works-for-all-sites UA many times.

Yes.

> > Source/WebCore/platform/gtk/UserAgentGtk.cpp:146
> > +        uaString.appendLiteral(" Version/6.0");
> 
> Some users reported that some sites where complaining about using an old Safari version. Should we use 7.0 (or the most recent one)?

I don't know, I didn't want to change the current behaviour for the specific sites that caused the UA changes.

> > Source/WebCore/platform/gtk/UserAgentGtk.cpp:189
> > +    }
> 
> We used to have rules also for google domains in WK1. Time to resurrect them?

Yes, but again, I wanted this patch to fix the sites that required to change the UA string lately, and at the same time fix all other sites that don't require it and were doing weird things, like bugzilla setting your OS as MAC OS or sites that offer the mac download instead of the linux one. 

Once this patch lands, we can add new specific site quirks like google sites easily.

[Carlos Garcia Campos]

We should probably also change the enable-site-specific-quirks setting default value to TRUE when thnis patch lands. What do you think?

[Carlos Garcia Campos]

Created attachment 232118 [details]
Updated patch

Rebased to apply on current git master and changed the default value of the site specific quirks setting.

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Build Bot]

Comment on attachment 232118 [details]
Updated patch

Attachment 232118 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5189048809291776

New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html

[Build Bot]

Created attachment 232122 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Sergio Villar Senin]

www.icloud.com reports unsupported browser even with the "Safari v6" thing. That's why I thing that seems to be too old. Something to take into account when adding site specific quirks

[Carlos Garcia Campos]

(In reply to comment #12)
> www.icloud.com reports unsupported browser even with the "Safari v6" thing. That's why I thing that seems to be too old. Something to take into account when adding site specific quirks

Ok, I want to land this patch first as a base and then add google and any other site specific quirks.

[Carlos Garcia Campos]

Could a WebKit2 owner review the cross-platform changes, please?

[Carlos Garcia Campos]

Committed r169799: <http://trac.webkit.org/changeset/169799>