Summary: | Fix build errors for BlobDataItem after r168391 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Praveen Jadhav <praveen.j> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, berto, cdumez, cgarcia, commit-queue, danw, dev_sachin, gustavo, gyuyoung.kim, mrobinson, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 132628 | ||||||||
Attachments: |
|
Description
Praveen Jadhav
2014-05-06 23:29:19 PDT
Created attachment 230974 [details]
Patch
Patch
Attachment 230974 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:783: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:792: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:793: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230974&action=review > Source/WebCore/ChangeLog:6 > + Build error fix. This doesn't provide any useful information, since the summary already says Fix build errors ... > Source/WebCore/ChangeLog:10 > + No new tests. No change in behaviour. You should remove this, commit-queue will refuse to commit this if this line is present in the changelog. > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:783 > soup_message_body_append(message->request_body, SOUP_MEMORY_TEMPORARY, > - blobItem.data->data() + blobItem.offset, blobItem.length); > + blobItem.data->data() + blobItem.offset(), blobItem.length()); Even if this was already using the old coding style, we can take advantage we are changing it now to use the new coding style, please fix it. > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:794 > - blobItem.path, > - blobItem.offset, > - blobItem.length == BlobDataItem::toEndOfFile ? 0 : blobItem.length, > + blobItem.file->path(), > + blobItem.offset(), > + blobItem.length() == BlobDataItem::toEndOfFile ? 0 : blobItem.length(), Ditto. Created attachment 230975 [details]
Patch
All comments are considered.
Comment on attachment 230975 [details]
Patch
Thanks!
Comment on attachment 230975 [details] Patch Clearing flags on attachment: 230975 Committed r168413: <http://trac.webkit.org/changeset/168413> All reviewed patches have been landed. Closing bug. Sorry about the breakage, and thank you for the fix! |