Bug 132626

Summary: Can't make a booking at virginamerica.com
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, cdumez, cgarcia, commit-queue, jsbell, mkwst, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Oliver Hunt 2014-05-06 15:02:59 PDT 
Can't make a booking at virginamerica.com
Comment 1 Oliver Hunt 2014-05-06 15:08:03 PDT 
Created attachment 230936 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-06 15:12:36 PDT 
Comment on attachment 230936 [details]
Patch

r=me
Comment 3 Oliver Hunt 2014-05-06 15:17:37 PDT 
Committed r168385: <http://trac.webkit.org/changeset/168385>
Comment 4 Csaba Osztrogonác 2014-05-06 23:51:46 PDT 
(In reply to comment #3)
> Committed r168385: <http://trac.webkit.org/changeset/168385>

It broke the Apple Windows build.
Comment 5 Csaba Osztrogonác 2014-05-06 23:56:27 PDT 
The build is still broken on ToT after the not mentioned buildfix attempt - https://trac.webkit.org/changeset/168389 :

    1>WebCoreTestSupport.lib(JSTypeConversions.obj) : error LNK2019: unresolved external symbol "void __cdecl WebCore::reportDeprecatedSetterError(class JSC::ExecState &,char const *,char const *)" (?reportDeprecatedSetterError@WebCore@@YAXAAVExecState@JSC@@PBD1@Z) referenced in function "public: static bool __cdecl WebCore::JSTypeConversionsPrototype::getOwnPropertySlot(class JSC::JSObject *,class JSC::ExecState *,class JSC::PropertyName,class JSC::PropertySlot &)" (?getOwnPropertySlot@JSTypeConversionsPrototype@WebCore@@SA_NPAVJSObject@JSC@@PAVExecState@4@VPropertyName@4@AAVPropertySlot@4@@Z)
     1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals
     1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj" (Build target(s)) -- FAILED.

Build FAILED.