Bug 132623

Summary:

[iOS][WK2] Add tap highlight on the simple UITapGestureRecognizer

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

133349

Attachments:

Description	Flags
Patch	none
Patch	none

Benjamin Poulain

Reported 2014-05-06 14:16:27 PDT

[iOS][WK2] Add tap highlight on the simple UITapGestureRecognizer

Attachments
Patch (36.71 KB, patch) 2014-05-06 14:17 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (36.37 KB, patch) 2014-05-06 14:23 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-05-06 14:17:32 PDT

Created attachment 230932 [details] Patch

Benjamin Poulain

Comment 2 2014-05-06 14:23:16 PDT

Created attachment 230933 [details] Patch

WebKit Commit Bot

Comment 3 2014-05-06 14:24:05 PDT

Attachment 230933 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:437: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:452: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:456: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:664: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:667: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:667: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:669: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:671: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:801: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:802: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:804: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 19 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Enrica Casucci

Comment 4 2014-05-06 15:01:14 PDT

Comment on attachment 230933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230933&action=review Looks good to me. > Source/WebKit2/UIProcess/ios/WKSyntheticClickTapGestureRecognizer.h:25 > + you need to add #if PLATFORM(IOS) around the entire file content. > Source/WebKit2/UIProcess/ios/WKSyntheticClickTapGestureRecognizer.m:25 > + Ditto.

Benjamin Poulain

Comment 5 2014-05-06 15:53:45 PDT

Committed r168388: <http://trac.webkit.org/changeset/168388>

Note You need to log in before you can comment on or make changes to this bug.