Bug 132609

Summary: [GStreamer] Corrected typo
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Xabier Rodríguez Calvar
Reported 2014-05-06 09:00:58 PDT
[GStreamer] Corrected typo
Attachments
Patch (3.94 KB, patch)
2014-05-06 09:03 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2014-05-06 09:20 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.99 KB, patch)
2014-05-07 03:17 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2014-05-06 09:03:57 PDT
Created attachment 230909 [details] Patch
Martin Robinson
Comment 2 2014-05-06 09:05:33 PDT
Comment on attachment 230909 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230909&action=review Please fix ChangeLog before landing. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208 > , m_timeOfOverlappingSeek(-1) > + , m_canFallBackToLastFinishedSeekPosition(false) > , m_buffering(false) This is a goo thing to add, I'd say, but you fail to mention it in the ChangeLog.
Xabier Rodríguez Calvar
Comment 3 2014-05-06 09:09:02 PDT
(In reply to comment #2) > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208 > > , m_timeOfOverlappingSeek(-1) > > + , m_canFallBackToLastFinishedSeekPosition(false) > > , m_buffering(false) > > This is a good thing to add, I'd say, but you fail to mention it in the ChangeLog. It is in the changelog. Should I add anything else?
Xabier Rodríguez Calvar
Comment 4 2014-05-06 09:20:09 PDT
Created attachment 230910 [details] Patch
WebKit Commit Bot
Comment 5 2014-05-07 01:45:19 PDT
Comment on attachment 230910 [details] Patch Rejecting attachment 230910 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 230910, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5328062841356288
Xabier Rodríguez Calvar
Comment 6 2014-05-07 03:17:00 PDT
Created attachment 230983 [details] Patch for landing
WebKit Commit Bot
Comment 7 2014-05-07 03:54:58 PDT
Comment on attachment 230983 [details] Patch for landing Clearing flags on attachment: 230983 Committed r168420: <http://trac.webkit.org/changeset/168420>
WebKit Commit Bot
Comment 8 2014-05-07 03:55:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.