Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI

• Component: Web Inspector
• Status: RESOLVED FIXED

[Radu Stavila]

Add the regionOversetChange event to the iOS 7.0 WebInspector UI

[Radar WebKit Bug Importer]

<rdar://problem/16811884>

[Radu Stavila]

Created attachment 230898 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 230898 [details]
Patch

Clearing flags on attachment: 230898

Committed r168355: <http://trac.webkit.org/changeset/168355>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 230898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230898&action=review

> Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json:2192
> +            {
> +                "name": "regionOversetChanged",
> +                "parameters": [
> +                    { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." }
> +                ],
> +                "description": "Fires if any of the regionOverset values changed in a Named Flow's region chain."

Does adding this to the iOS 7 version actually fix an issue for you inspecting an iOS 7 device?

The reason this is not in iOS-7.0 was because it did not exist in iOS 7. This change is not correct, but it is harmless. I think we should back it out.

Only InspectorInstrumentation::didUpdateRegionLayout existed in iOS 7, InspectorInstrumentation::didChangeRegionOverset came later and is not in any iOS 7 release, so this event will never happen.

[Radu Stavila]

Hi Joe,
My mistake, I was under the impression the regionOversetChange event made it into iOS7. I will remove it. And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector). Should I also add that event back into the iOS7 inspector? (that event actually exists in iOS7)

[Joseph Pecoraro]

(In reply to comment #6)
> My mistake, I was under the impression the regionOversetChange event made it into iOS7.

Maybe the DOM event existed but the WebInspector hook for the event did not exist.

> And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector).

Could you point me to the change you made? I can work back from there to see if it was good or not.

[Radu Stavila]

https://bugs.webkit.org/show_bug.cgi?id=132564

[Joseph Pecoraro]

(In reply to comment #8)
> https://bugs.webkit.org/show_bug.cgi?id=132564

Thanks for the pointer. Yeah, it looks like we should leave in the bits for handling "regionLayoutUpdate" in the frontend for backwards compatibility and the best debugging experience for iOS 7. More comments in that bug.

[Radu Stavila]

Created https://bugs.webkit.org/show_bug.cgi?id=132731