Summary: | jsSubstring() should be lazy | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | barraclough, ggaren, kling, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2014-05-04 21:01:56 PDT
Created attachment 230807 [details]
the patch
Comment on attachment 230807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=230807&action=review r=me > Source/JavaScriptCore/heap/MarkedBlock.cpp:73 > + SamplingRegion samplingRegion((dtorType != MarkedBlock::None && blockState != New) ? "Calling destructors" : "sweeping"); Looks unrelated. Landed in http://trac.webkit.org/changeset/168254 Reverted r168254 for reason: Very crashy on debug JSC tests. Committed r168255: <http://trac.webkit.org/changeset/168255> |