Bug 132556

Summary: jsSubstring() should be lazy
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: REOPENED    
Severity: Normal CC: barraclough, ggaren, kling, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch kling: review+

Filip Pizlo
Reported 2014-05-04 21:01:56 PDT
Patch forthcoming.
Attachments
the patch (22.96 KB, patch)
2014-05-04 21:12 PDT, Filip Pizlo 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-05-04 21:12:53 PDT
Created attachment 230807 [details] the patch
Andreas Kling
Comment 2 2014-05-04 21:52:38 PDT
Comment on attachment 230807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=230807&action=review r=me > Source/JavaScriptCore/heap/MarkedBlock.cpp:73 > + SamplingRegion samplingRegion((dtorType != MarkedBlock::None && blockState != New) ? "Calling destructors" : "sweeping"); Looks unrelated.
Filip Pizlo
Comment 3 2014-05-04 21:57:47 PDT
Landed in http://trac.webkit.org/changeset/168254
Andreas Kling
Comment 4 2014-05-04 23:10:36 PDT
Reverted r168254 for reason: Very crashy on debug JSC tests. Committed r168255: <http://trac.webkit.org/changeset/168255>
Note You need to log in before you can comment on or make changes to this bug.