Bug 132553

Summary: [iOS][WK2] Special case ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture() for image documents
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2014-05-04 19:33:58 PDT
[iOS][WK2] Special case ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture() for image documents
Attachments
Patch (6.36 KB, patch)
2014-05-04 19:37 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (9.91 KB, patch)
2014-05-05 14:02 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-05-04 19:37:47 PDT
Created attachment 230804 [details] Patch
Tim Horton
Comment 2 2014-05-04 19:41:23 PDT
Comment on attachment 230804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230804&action=review > Source/WebCore/html/ImageDocument.h:33 > +class HTMLImageElement; Why is this here? > Source/WebCore/html/ImageDocument.h:42 > + Element* imageElement() const; Can this type be more specific? Can it be a reference? > Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:94 > +#if PLATFORM(IOS) I think you should do this everywhere, not just iOS.
Benjamin Poulain
Comment 3 2014-05-05 14:02:52 PDT
Created attachment 230855 [details] Patch
Benjamin Poulain
Comment 4 2014-05-05 14:13:47 PDT
Comment on attachment 230855 [details] Patch Clearing flags on attachment: 230855 Committed r168316: <http://trac.webkit.org/changeset/168316>
Benjamin Poulain
Comment 5 2014-05-05 14:13:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.