| Summary: | [iOS WK2] Turn off position:fixed behavior when the keyboard is up | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, benjamin, cmarcelo, commit-queue, jamesr, jonlee, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2014-05-03 17:28:39 PDT
Created attachment 230773 [details]
Patch
Created attachment 230774 [details]
Patch
Comment on attachment 230774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230774&action=review Cool! If you have time, it would be really nice to not freeze the layout in some cases. If you can fix the caret issue, I would be happy to come with the heuristic and fix the animation. > Source/WebKit2/UIProcess/ios/WKContentView.mm:316 > + _lastFixedPositionRect = fixedPositionRectFromExposedRect(unobscuredRect, [self bounds].size, zoomScale); We should rename fixedPositionRectFromExposedRect() to fixedPositionRectFromUnobscuredRect() at some point. [self bounds].size -> self.bounds.size. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2105 > +- (BOOL)_hasAssistedNode > +{ > + return _assistedNodeInformation.elementType != WKTypeNone; > +} Shouldn't you use "isEditable" and/or "isAssistingNode" instead? There's a problem when moving from one form field in a postion:fixed to the next, so I'll refine this patch. Comment on attachment 230774 [details]
Patch
Need to do something better than this.
Created attachment 235244 [details]
Patch
Comment on attachment 235244 [details]
Patch
Looks reasonable.
Can you please force an updateVisibleContentRect from [WKContentView _startAssistingNode:] in if the focus succeed and the AssistedNodeInformation has insideFixedPosition? (if not you could remove insideFixedPosition entirely).
|