Summary: | [iOS] deviceScaleFactor is being double-applied when rendering captions in full screen mode | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Critical | CC: | calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 132498 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Brent Fulgham
2014-05-02 12:32:58 PDT
Created attachment 230685 [details]
Patch
Comment on attachment 230685 [details]
Patch
r=me
Committed r168192: <http://trac.webkit.org/changeset/168192> Re-opened since this is blocked by bug 132498 Created attachment 230726 [details]
Patch
Comment on attachment 230726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230726&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1605 > + if (representationLayer == m_textTrackRepresentationLayer) { > + if (m_videoFullscreenLayer && m_textTrackRepresentationLayer) { > + // Keep our text track layer in sync with the video layer at all times > + CGRect textFrame = m_videoLayer ? [m_videoLayer videoRect] : CGRectMake(0, 0, m_videoFullscreenFrame.width(), m_videoFullscreenFrame.height()); > + [m_textTrackRepresentationLayer setFrame:textFrame]; > + } This is good, but it will miss when the video changes sizes during a single cue display. (I.e., changing rotation while a cue is up will not cause a re-layout.) Brent and I discussed over IRC and alternate possibility for fixing this. Created attachment 230738 [details]
Patch
Comment on attachment 230738 [details]
Patch
Nice! r=me
Comment on attachment 230738 [details] Patch Clearing flags on attachment: 230738 Committed r168245: <http://trac.webkit.org/changeset/168245> All reviewed patches have been landed. Closing bug. |