Bug 132481

Summary: [iOS] deviceScaleFactor is being double-applied when rendering captions in full screen mode
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Critical CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Bug Depends on: 132498    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brent Fulgham
Reported 2014-05-02 12:32:58 PDT
When captions are played in full screen mode, they are about half the size we would expect. It looks like we are configuring the text track representation's graphics context to scale by the device scale factor, but later we apply that device scale factor again when generating the final image we pass to the full screen compositing step.
Attachments
Patch (1.76 KB, patch)
2014-05-02 12:38 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2014-05-02 18:11 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (9.88 KB, patch)
2014-05-02 21:23 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-05-02 12:33:16 PDT
<rdar://problem/16507482>
Brent Fulgham
Comment 2 2014-05-02 12:38:22 PDT
Created attachment 230685 [details] Patch
Jer Noble
Comment 3 2014-05-02 13:43:44 PDT
Comment on attachment 230685 [details] Patch r=me
Brent Fulgham
Comment 4 2014-05-02 14:39:55 PDT
Committed r168192: <http://trac.webkit.org/changeset/168192>
WebKit Commit Bot
Comment 5 2014-05-02 15:54:44 PDT
Re-opened since this is blocked by bug 132498
Brent Fulgham
Comment 6 2014-05-02 18:11:41 PDT
Created attachment 230726 [details] Patch
Jer Noble
Comment 7 2014-05-02 18:28:33 PDT
Comment on attachment 230726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230726&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1605 > + if (representationLayer == m_textTrackRepresentationLayer) { > + if (m_videoFullscreenLayer && m_textTrackRepresentationLayer) { > + // Keep our text track layer in sync with the video layer at all times > + CGRect textFrame = m_videoLayer ? [m_videoLayer videoRect] : CGRectMake(0, 0, m_videoFullscreenFrame.width(), m_videoFullscreenFrame.height()); > + [m_textTrackRepresentationLayer setFrame:textFrame]; > + } This is good, but it will miss when the video changes sizes during a single cue display. (I.e., changing rotation while a cue is up will not cause a re-layout.) Brent and I discussed over IRC and alternate possibility for fixing this.
Brent Fulgham
Comment 8 2014-05-02 21:23:16 PDT
Created attachment 230738 [details] Patch
Jer Noble
Comment 9 2014-05-02 21:36:34 PDT
Comment on attachment 230738 [details] Patch Nice! r=me
WebKit Commit Bot
Comment 10 2014-05-04 14:01:52 PDT
Comment on attachment 230738 [details] Patch Clearing flags on attachment: 230738 Committed r168245: <http://trac.webkit.org/changeset/168245>
WebKit Commit Bot
Comment 11 2014-05-04 14:02:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.