Summary: | Update service picker API usage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, thorton | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brady Eidson
2014-05-01 17:43:12 PDT
Created attachment 230635 [details]
Patch v1
Attachment 230635 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:171: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230635 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=230635&action=review > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:113 > + data = [nsImage.get() TIFFRepresentation]; no .get() > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:166 > + [self didShareImageData :[item TIFFRepresentation] confirmDataIsValidTIFFData:NO]; colon is in way the wrong place > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:169 > + NSString *itemUTI = itemProvider.registeredTypeIdentifiers.firstObject; firstObject is not available on ML IIRC > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:370 > + RetainPtr<CFDataRef> cfdata = data->createCFData(); capital D (In reply to comment #3) > (From update of attachment 230635 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230635&action=review > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:113 > > + data = [nsImage.get() TIFFRepresentation]; > > no .get() > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:166 > > + [self didShareImageData :[item TIFFRepresentation] confirmDataIsValidTIFFData:NO]; > > colon is in way the wrong place > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:169 > > + NSString *itemUTI = itemProvider.registeredTypeIdentifiers.firstObject; > > firstObject is not available on ML IIRC Neither is this code, never mind. > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:370 > > + RetainPtr<CFDataRef> cfdata = data->createCFData(); > > capital D Created attachment 230646 [details]
Patch for landing
Attachment 230646 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:171: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230646 [details] Patch for landing Clearing flags on attachment: 230646 Committed r168145: <http://trac.webkit.org/changeset/168145> All reviewed patches have been landed. Closing bug. |