Bug 132423

Summary:

Calling createLinearGradient and createRadialGradient with non-finite data should generate a type error

Product:

WebKit

Reporter:

Rik Cabanier <cabanier>

Component:

Canvas

Assignee:

Rik Cabanier <cabanier>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, krit, mike

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Rik Cabanier 2014-05-01 00:51:44 PDT

Currently this generate a NOT_SUPPORTED_ERROR which is wrong per the WebIDL spec: http://www.w3.org/TR/WebIDL/#es-double

This patch will make WK match Firefox.

Comment 1 Rik Cabanier 2014-05-01 00:57:14 PDT

Created attachment 230572 [details]
Patch

Comment 2 Dirk Schulze 2014-05-01 01:17:52 PDT

(In reply to comment #1)
> Created an attachment (id=230572) [details]
> Patch

Maybe you really should look into the code generation. It is not that bad actually even though it is written in Perl.

It is in bindings/scripts

Comment 3 Andreas Kling 2014-05-01 12:24:04 PDT

Comment on attachment 230572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230572&action=review

> Source/WebCore/ChangeLog:13
> +        * canvas/philip/tests/2d.gradient.linear.nonfinite.html:
> +        * canvas/philip/tests/2d.gradient.radial.nonfinite.html:

This is an imported test suite; do your changes match upstream?

Comment 4 Rik Cabanier 2014-05-01 13:19:35 PDT

(In reply to comment #3)
> (From update of attachment 230572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230572&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        * canvas/philip/tests/2d.gradient.linear.nonfinite.html:
> > +        * canvas/philip/tests/2d.gradient.radial.nonfinite.html:
> 
> This is an imported test suite; do your changes match upstream?

yes,this test suite is now maintained by the w3c and this particular test was already updated
see http://www.w3c-test.org/2dcontext/fill-and-stroke-styles/2d.gradient.linear.nonfinite.html

I'm looking over the cases where WK is not spec compliant

Comment 5 Rik Cabanier 2014-05-05 14:06:10 PDT

This was fixed by updating the IDL compiler

*** This bug has been marked as a duplicate of bug 132460 ***

Comment 6 Csaba Osztrogonác 2014-06-04 00:55:10 PDT

Comment on attachment 230572 [details]
Patch

Cleared review? from attachment 230572 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).