| Summary: | fast/multicol/fixed-stack.html failing since introduction. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ap, bfulgham, clopez, darin, kling, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=159214 | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2014-05-01 00:15:05 PDT
Skipped: <http://trac.webkit.org/changeset/168090> Seems like this should have gotten ImageOnlyFailure'd, not Skipped! That way we'll still learn if the text parts differ and just ignore the bad image parts. Hmmm not sure how to fix. The whole point was to compare compositing vs. non-compositing, so if the images aren't going to match I'm not sure how to test this issue. I guess I should turn it into a pixel test. Updated the expectation in <http://trac.webkit.org/r168106>. (In reply to comment #3) > Hmmm not sure how to fix. The whole point was to compare compositing vs. non-compositing, so if the images aren't going to match I'm not sure how to test this issue. It would be nice to have a link to the failure here so we can see what kind of AA differences are occuring. Ideally there should be no differences between the two modes, and you shouldn't have to worry about this when writing a test. Andreas, did it fail on WebKit2 bots as well? (i.e. was the issue with the whole webview being in compositing/not, which only switches on WebKit1 bots, or with the content specifically being in compositing/not, which switches on both). http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r168079%20(18114)/fast/multicol/fixed-stack-diffs.html http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r168087%20(5354)/fast/multicol/fixed-stack-diffs.html It was WK2 only, for added surprise :). Failing consistently on all Mac WK2 bots. This test pass on GTK (WK2) As of Yosemite, the test now fails on WK1 too, because it actually started to use compositing. Updated expectations in <http://trac.webkit.org/r175170>. (In reply to comment #9) > As of Yosemite, the test now fails on WK1 too, because it actually started > to use compositing. > > Updated expectations in <http://trac.webkit.org/r175170>. After this test expectation change, Windows now passes as well. Created attachment 447777 [details]
Patch
|