Bug 132405

Summary:

REGRESSION(r168041): http/tests/navigation/no-referrer-reset.html crashes on Mavericks WK1

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

History

Assignee:

Brian Burg <burg>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

andersca, ap, benjamin, darin, kling, mmaxfield, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

131637

Attachments:

Description	Flags
the patch	none
the patch	none

Description Brian Burg 2014-04-30 15:31:46 PDT

Fix forthcoming. Basically, I forgot to iron out/remove BackForwardClient::close(), which is no longer necessary since the client's lifetime is tied to the owning BackForwardController or WebBackForwardList.

Comment 1 Brian Burg 2014-04-30 15:41:50 PDT

Created attachment 230531 [details]
the patch

Comment 2 Andreas Kling 2014-04-30 16:59:31 PDT

Comment on attachment 230531 [details]
the patch

Regressions: Unexpected text-only failures (27)
  compositing/plugins/composited-plugin.html [ Failure ]
  compositing/plugins/no-backing-store.html [ Failure ]
  compositing/plugins/small-to-large-composited-plugin.html [ Failure ]
  fast/frames/sandboxed-iframe-about-blank.html [ Failure ]
  fast/frames/sandboxed-iframe-navigation-allowed.html [ Failure ]
  fast/frames/sandboxed-iframe-plugins.html [ Failure ]
  fast/replaced/invalid-object-with-fallback.html [ Failure ]
  http/tests/plugins/create-v8-script-objects.html [ Failure ]
  http/tests/plugins/cross-frame-object-access.html [ Failure ]
  http/tests/plugins/get-url-beforeunload-destroys-plugin.html [ Failure ]
  platform/mac/plugins/convert-point.html [ Failure ]
  plugins/destroy-during-npp-new.html [ Failure ]
  plugins/destroy-plugin-from-callback.html [ Failure ]
  plugins/npruntime/browser-object-identity.html [ Failure ]
  plugins/npruntime/construct.html [ Failure ]
  plugins/npruntime/delete-plugin-within-invoke.html [ Failure ]
  plugins/npruntime/embed-property-equality.html [ Failure ]
  plugins/npruntime/embed-property-iframe-equality.html [ Failure ]
  plugins/npruntime/embed-property.html [ Failure ]
  plugins/npruntime/enumerate.html [ Failure ]
  plugins/npruntime/evaluate.html [ Failure ]
  plugins/npruntime/get-int-identifier-special-values.html [ Failure ]
  plugins/npruntime/get-property-return-value.html [ Failure ]
  plugins/npruntime/identifier-conversion.html [ Failure ]
  plugins/npruntime/invoke-browserfuncs.html [ Failure ]
  plugins/npruntime/invoke-default.html [ Failure ]
  plugins/npruntime/invoke.html [ Failure ]

Regressions: Unexpected timeouts (3)
  fast/loader/image-in-page-cache.html [ Timeout ]
  http/tests/navigation/no-referrer-reset.html [ Timeout ]
  loader/load-defer-resume-crash.html [ Timeout ]

Comment 3 Brian Burg 2014-04-30 17:51:36 PDT

Still a few things wrong.

WK1's WebBackForwardList is unconditionally freeing its backForwardList, but if the WebBackForwardList was initialized using initaliazeWithBackForwardList:backForwardList, then it doesn't own that list and shouldn't try to delete it.

Comment 4 Brian Burg 2014-04-30 18:02:39 PDT

Created attachment 230550 [details]
the patch

Comment 5 Brian Burg 2014-04-30 22:18:14 PDT

(In reply to comment #2)
> (From update of attachment 230531 [details])
> Regressions: Unexpected text-only failures (27)
>   compositing/plugins/composited-plugin.html [ Failure ]
>   compositing/plugins/no-backing-store.html [ Failure ]
>   compositing/plugins/small-to-large-composited-plugin.html [ Failure ]
>   fast/frames/sandboxed-iframe-about-blank.html [ Failure ]
>   fast/frames/sandboxed-iframe-navigation-allowed.html [ Failure ]
>   fast/frames/sandboxed-iframe-plugins.html [ Failure ]
>   fast/replaced/invalid-object-with-fallback.html [ Failure ]
>   http/tests/plugins/create-v8-script-objects.html [ Failure ]
>   http/tests/plugins/cross-frame-object-access.html [ Failure ]
>   http/tests/plugins/get-url-beforeunload-destroys-plugin.html [ Failure ]
>   platform/mac/plugins/convert-point.html [ Failure ]
>   plugins/destroy-during-npp-new.html [ Failure ]
>   plugins/destroy-plugin-from-callback.html [ Failure ]
>   plugins/npruntime/browser-object-identity.html [ Failure ]
>   plugins/npruntime/construct.html [ Failure ]
>   plugins/npruntime/delete-plugin-within-invoke.html [ Failure ]
>   plugins/npruntime/embed-property-equality.html [ Failure ]
>   plugins/npruntime/embed-property-iframe-equality.html [ Failure ]
>   plugins/npruntime/embed-property.html [ Failure ]
>   plugins/npruntime/enumerate.html [ Failure ]
>   plugins/npruntime/evaluate.html [ Failure ]
>   plugins/npruntime/get-int-identifier-special-values.html [ Failure ]
>   plugins/npruntime/get-property-return-value.html [ Failure ]
>   plugins/npruntime/identifier-conversion.html [ Failure ]
>   plugins/npruntime/invoke-browserfuncs.html [ Failure ]
>   plugins/npruntime/invoke-default.html [ Failure ]
>   plugins/npruntime/invoke.html [ Failure ]
> 
> Regressions: Unexpected timeouts (3)
>   fast/loader/image-in-page-cache.html [ Timeout ]
>   http/tests/navigation/no-referrer-reset.html [ Timeout ]
>   loader/load-defer-resume-crash.html [ Timeout ]

Plugin failures are probably from WebKitLegacy and related stormy weather today.

Comment 6 Alexey Proskuryakov 2014-04-30 22:52:18 PDT

Resolved via rollout.