| Summary: | Fix PageVisibility on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
| Component: | WebKit2 | Assignee: | Gavin Barraclough <barraclough> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gavin Barraclough
2014-04-30 11:50:19 PDT
Created attachment 230508 [details]
Fix
Attachment 230508 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:48: The parameter name "throttler" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:48: The parameter name "visibility" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:69: The parameter name "visibility" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:99: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 4 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230508 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=230508&action=review r=me I'd probably out-of-line the ProcessThottler.h stuff since it's included from everywhere in WK2. > Source/WebKit2/UIProcess/WebProcessProxy.h:138 > + ProcessThrottler& throttler() { return *m_throttler.get(); } You don't need the .get() here. > Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:35 > +const BKSProcessAssertionFlags suspenedTabFlags = (BKSProcessAssertionAllowIdleSleep); Typo, should be suspendedTabFlags. Transmitting file data ................ Committed revision 168038. |