| Summary: | [New Multicolumn] ASSERTs in fast/dynamic/continuation-detach-crash.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 131825 | ||||||
| Attachments: |
|
||||||
|
Description
Dave Hyatt
2014-04-30 11:40:34 PDT
Created attachment 230517 [details]
Patch
Attachment 230517 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:39: RenderMultiColumnFlowThread::g_shiftingSpanner is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:304: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderMultiColumnFlowThread.h:153: g_shiftingSpanner is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|