Summary: | AX: Make "contenteditable" regions into AXTextAreas | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||||||||||||||||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||||||
Attachments: |
|
Description
chris fleizach
2014-04-29 23:34:13 PDT
Created attachment 230462 [details]
patch
Comment on attachment 230462 [details] patch Attachment 230462 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6288148757741568 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230465 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 230466 [details]
patch
Comment on attachment 230466 [details] patch Attachment 230466 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5244480294748160 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230470 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 230466 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230466&action=review Looks good, just a couple of comments below > LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.txt:32 > + AXMarkedMisspelled = 1; This line is not being output when running the test in the Mac bots. Guess you should just remove it from here? > LayoutTests/platform/mac/accessibility/content-editable-as-textarea.html:32 > + window.testRunner.notifyDone(); > + } > + } > + > + if (window.accessibilityController) { > + window.testRunner.waitUntilDone(); I think the "trend" these days is to declare window.jsTestIsAsync = true; and call finishJSTest() when done, instead of using waitUntilDone() and notifyDone(). Could you change that before landing? Comment on attachment 230466 [details] patch Attachment 230466 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5844894174150656 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230471 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 230466 [details] patch Attachment 230466 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5335704326373376 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230472 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 230479 [details]
patch
Thanks Mario
Patch for landing…
Comment on attachment 230479 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230479&action=review > LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.txt:32 > + AXMarkedMisspelled = 1; Did you intentionally left this one here? Comment on attachment 230479 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230479&action=review >> LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.txt:32 >> + AXMarkedMisspelled = 1; > > Did you intentionally left this one here? ugh, i keep trying to add a mac-mountainlion test specific for this but keep forgetting something (like svn add) Created attachment 230482 [details]
patch for landing
Comment on attachment 230482 [details] patch for landing Attachment 230482 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4947462905135104 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230488 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
(In reply to comment #16) > (From update of attachment 230482 [details]) > Attachment 230482 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/4947462905135104 > > New failing tests: > platform/mac/accessibility/content-editable-as-textarea.html It looks to me like you might need another platform specific expectation for mac-wk2. Or maybe just one for mac/? Comment on attachment 230482 [details] patch for landing Attachment 230482 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5073060835098624 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230491 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
(In reply to comment #18) > (In reply to comment #16) > > (From update of attachment 230482 [details] [details]) > > Attachment 230482 [details] [details] did not pass mac-wk2-ews (mac-wk2): > > Output: http://webkit-queues.appspot.com/results/4947462905135104 > > > > New failing tests: > > platform/mac/accessibility/content-editable-as-textarea.html > > It looks to me like you might need another platform specific expectation for mac-wk2. Or maybe just one for mac/? Maybe sub-platform specific test results don't work when it's already a platform test? Comment on attachment 230482 [details] patch for landing Attachment 230482 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5352014666006528 New failing tests: platform/mac/accessibility/content-editable-as-textarea.html Created attachment 230500 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 230514 [details]
patch for landing
Moved this to the AX folder and have specific platform results. GTK can add in their results too
|