Bug 132359

Summary:

[iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Sam Weinig 2014-04-29 15:00:58 PDT

[iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS

Comment 1 Sam Weinig 2014-04-29 15:03:59 PDT

Created attachment 230425 [details]
Patch

Comment 2 WebKit Commit Bot 2014-04-29 15:06:27 PDT

Attachment 230425 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6588:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2014-04-30 10:27:09 PDT

Committed r168029: <http://trac.webkit.org/changeset/168029>