Summary: | Zombifying sweep should ignore retired blocks | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-04-29 11:02:58 PDT
Created attachment 230391 [details]
the patch.
Comment on attachment 230391 [details]
the patch.
r=me
Thanks. Landed in r167948: <http://trac.webkit.org/r167948>. Why did you do this? Does this fix a bug in zombie mode? Improve performance? (In reply to comment #4) > Why did you do this? > > Does this fix a bug in zombie mode? Improve performance? This fixes a bug when running with zombie mode. This is needed because unlike the default sweeper that only sweeps after a full collection (which ensures there are no retired blocks during a sweep), the zombie sweep can happen with just an eden collection (and hence, retired blocks can exists, and we'll fail an assertion if we don't ignore them). |