Bug 132336

Summary: [Mac] support media engine starting/stopping playback
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED ---    
Severity: Normal CC: buildbot, commit-queue, glenn, jer.noble, philipj, rniwa, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
none
Updated patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion none

Description Eric Carlson 2014-04-29 07:20:37 PDT
In bug 130480 we added code to allow the media engine to start and stop playback when playing to an external device. Generalize that code because the media engine can start and stop playback in other situations as well.
Comment 1 Eric Carlson 2014-04-29 10:01:09 PDT
Created attachment 230385 [details]
Proposed patch.
Comment 2 Build Bot 2014-04-29 11:00:18 PDT
Comment on attachment 230385 [details]
Proposed patch.

Attachment 230385 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5399326213799936

New failing tests:
media/track/track-mode.html
media/media-controller-playbackrate.html
media/video-seek-past-end-playing.html
Comment 3 Build Bot 2014-04-29 11:00:22 PDT
Created attachment 230390 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-04-29 11:22:27 PDT
Comment on attachment 230385 [details]
Proposed patch.

Attachment 230385 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5757753851117568

New failing tests:
media/video-loop.html
media/track/track-mode.html
media/media-controller-playbackrate.html
media/video-played-collapse.html
media/video-seek-past-end-playing.html
Comment 5 Build Bot 2014-04-29 11:22:31 PDT
Created attachment 230392 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-04-29 12:31:42 PDT
Comment on attachment 230385 [details]
Proposed patch.

Attachment 230385 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6666003069009920

New failing tests:
media/video-loop.html
media/track/track-mode.html
media/media-controller-playbackrate.html
media/video-seek-past-end-playing.html
Comment 7 Build Bot 2014-04-29 12:31:45 PDT
Created attachment 230400 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Eric Carlson 2014-04-30 22:05:09 PDT
Created attachment 230561 [details]
Updated patch
Comment 9 Build Bot 2014-05-01 00:56:18 PDT
Comment on attachment 230561 [details]
Updated patch

Attachment 230561 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4863443345604608

New failing tests:
media/media-controller-playbackrate.html
Comment 10 Build Bot 2014-05-01 00:56:22 PDT
Created attachment 230571 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 11 Build Bot 2014-05-01 04:25:49 PDT
Created attachment 230574 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5