Bug 132316

Summary: [iOS] Introduce -didNotHandleTapAsClickAtPoint: to WKUIDelegatePrivate
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Andy Estes
Reported 2014-04-28 18:41:20 PDT
[iOS] Introduce -didNotHandleTapAsClickAtPoint: to WKUIDelegatePrivate
Attachments
Patch (10.14 KB, patch)
2014-04-28 18:46 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (10.23 KB, patch)
2014-04-28 22:09 PDT, Andy Estes 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-04-28 18:46:38 PDT
Created attachment 230347 [details] Patch
Anders Carlsson
Comment 2 2014-04-28 21:43:39 PDT
Comment on attachment 230347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230347&action=review > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:182 > + auto delegate = m_uiDelegate.m_delegate.get(); You forgot to check m_delegateMethods.webViewDidNotHandleTapAsClickAtPoint here.
Andy Estes
Comment 3 2014-04-28 22:07:26 PDT
(In reply to comment #2) > (From update of attachment 230347 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230347&action=review > > > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:182 > > + auto delegate = m_uiDelegate.m_delegate.get(); > > You forgot to check m_delegateMethods.webViewDidNotHandleTapAsClickAtPoint here. Indeed. Thanks for the head's up.
Andy Estes
Comment 4 2014-04-28 22:09:47 PDT
Created attachment 230354 [details] Patch
Andy Estes
Comment 5 2014-04-29 09:57:06 PDT
Committed r167940: <http://trac.webkit.org/changeset/167940>
Note You need to log in before you can comment on or make changes to this bug.