Bug 132316

Summary:

[iOS] Introduce -didNotHandleTapAsClickAtPoint: to WKUIDelegatePrivate

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	darin: review+

Description Andy Estes 2014-04-28 18:41:20 PDT

[iOS] Introduce -didNotHandleTapAsClickAtPoint: to WKUIDelegatePrivate

Comment 1 Andy Estes 2014-04-28 18:46:38 PDT

Created attachment 230347 [details]
Patch

Comment 2 Anders Carlsson 2014-04-28 21:43:39 PDT

Comment on attachment 230347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230347&action=review

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:182
> +    auto delegate = m_uiDelegate.m_delegate.get();

You forgot to check m_delegateMethods.webViewDidNotHandleTapAsClickAtPoint here.

Comment 3 Andy Estes 2014-04-28 22:07:26 PDT

(In reply to comment #2)
> (From update of attachment 230347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230347&action=review
> 
> > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:182
> > +    auto delegate = m_uiDelegate.m_delegate.get();
> 
> You forgot to check m_delegateMethods.webViewDidNotHandleTapAsClickAtPoint here.

Indeed. Thanks for the head's up.

Comment 4 Andy Estes 2014-04-28 22:09:47 PDT

Created attachment 230354 [details]
Patch

Comment 5 Andy Estes 2014-04-29 09:57:06 PDT

Committed r167940: <http://trac.webkit.org/changeset/167940>