REGRESSION (r167751): svn-create-patch is very slow

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

svn-create-patch has become very slow, now that it runs check-webkit-style.

This is very annoying, especially because I frequently apply and unapply WIP patches locally.

[James Craig]

Weren't you one of the people who suggested running check-webkit-style should be the default? I don't think this bug is actionable unless you're requesting we change that. There is a --no-style flag that you can call or add as a default parameter to your bash profile.

[James Craig]

IOW, this is not any slower than running svn-create-patch + check-webkit-style. If your issue is that check-webkit-style is too slow, that seems like another matter. Which are you requesting?

[Alexey Proskuryakov]

> Weren't you one of the people who suggested running check-webkit-style should be the default? 

If I was, this demonstrates that this was not such a good idea. I didn't know that check-webkit-style was so slow and buggy.

Another use case where this is very annoying is running svn-create-patch to simply see what the current state of the tree is (what did I do?)

> Which are you requesting?

Given the current state of check-webkit-style, seems like it should not be invoked by svn-create-patch by default.

Changing bash profile on every machine just to make svn-create-patch not slow doesn't seem like the right workaround.

[Sam Weinig]

Created attachment 230329 [details]
Patch

[Sam Weinig]

(In reply to comment #2)
> IOW, this is not any slower than running svn-create-patch + check-webkit-style. If your issue is that check-webkit-style is too slow, that seems like another matter. Which are you requesting?

The real issue here is that svn-create-patch + check-webkit-style is not everyone's workflow.  I use svn-create-patch to stash files away all the time, and don't need a style check run.

[James Craig]

Comment on attachment 230329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230329&action=review

> Tools/Scripts/svn-create-patch:80
> +my $checkWebKitStyle = 0;

This is used as a boolean, so you can just remove " = 1" instead of setting it to 0.

[Sam Weinig]

Committed r167939: <http://trac.webkit.org/changeset/167939>

[Sam Weinig]

(In reply to comment #6)
> (From update of attachment 230329 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230329&action=review
> 
> > Tools/Scripts/svn-create-patch:80
> > +my $checkWebKitStyle = 0;
> 
> This is used as a boolean, so you can just remove " = 1" instead of setting it to 0.

I prefer it to be more explicit.