Summary: | [New Multicolumn] Implement support for compositing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, philipj, sergio, simon.fraser, WebkitBugTracker | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dave Hyatt
2014-04-28 13:13:01 PDT
Created attachment 230410 [details]
Patch
Comment on attachment 230410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230410&action=review > Source/WebCore/rendering/RenderLayer.cpp:2065 > + location.moveBy(region->topLeftLocation() + -parentLayer->renderBox()->topLeftLocation()); + - -> -? > Source/WebCore/rendering/RenderMultiColumnSet.cpp:826 > + LayoutUnit blockOffset = initialBlockOffset + (isHorizontalWritingMode() ? -flowThreadPortion.y() : -flowThreadPortion.x()); Change the plus with two minuses into a minus? > LayoutTests/ChangeLog:10 > + * compositing/columns/composited-columns-vertical-rl.html: I don't think you meant to change this. This change broke fast/multicol/mixed-positioning-stacking-order.html on WebKit2 bots: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r167977%20(5329)/fast/multicol/mixed-positioning-stacking-order-diffs.html (In reply to comment #4) > This change broke fast/multicol/mixed-positioning-stacking-order.html on WebKit2 bots: > > http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r167977%20(5329)/fast/multicol/mixed-positioning-stacking-order-diffs.html That's a progression, but I don't like how the test is rendering, so will probably try to find a way to keep compositing from happening. Let me come up with a tweak. |