Summary: | [GTK][cmake] CMake variable (non)expansion causing 'File name too long' build error. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikos Andronikos <nikos.andronikos> | ||||||||
Component: | Tools / Tests | Assignee: | Nikos Andronikos <nikos.andronikos> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, commit-queue, gyuyoung.kim, mrobinson, pnormand, rakuco, sergio, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Created attachment 230284 [details]
Patch
Interesting. The bug fix/behaviour change was introduced between CMake 2.8.7 and 2.8.8 in http://cmake.org/gitweb?p=cmake.git;a=commit;h=8adaee2b0b2651cfd93bb4a915d11bdd4cba1b51. I don't see a problem with this patch if we plan on supporting CMake 2.8.7 for a long time. I'd guess there are other places where we are passing lists to INCLUDE_DIRECTORIES(), have you checked that? (In reply to comment #2) > Interesting. The bug fix/behaviour change was introduced between CMake 2.8.7 and 2.8.8 in http://cmake.org/gitweb?p=cmake.git;a=commit;h=8adaee2b0b2651cfd93bb4a915d11bdd4cba1b51. > > I don't see a problem with this patch if we plan on supporting CMake 2.8.7 for a long time. I'd guess there are other places where we are passing lists to INCLUDE_DIRECTORIES(), have you checked that? I just checked - I cant see any other occurrences of lists passed to INCLUDE_DIRECTORIES() in quotes. Cool, thanks for checking. Looks good from my side. Comment on attachment 230284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230284&action=review > Source/WebCore/ChangeLog:5 > + Removing quotes around include directory variable ${WebCore_INCLUDE_DIRECTORIES} in > + the include_directories cmake macro enables the variable to be expanded correctly. Can you please move these 2 lines below the "Reviewed by" one? Comment on attachment 230284 [details]
Patch
Nice fix!
Created attachment 230447 [details]
Patch
(In reply to comment #5) > (From update of attachment 230284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230284&action=review > > > Source/WebCore/ChangeLog:5 > > + Removing quotes around include directory variable ${WebCore_INCLUDE_DIRECTORIES} in > > + the include_directories cmake macro enables the variable to be expanded correctly. > > Can you please move these 2 lines below the "Reviewed by" one? Done. (In reply to comment #6) > (From update of attachment 230284 [details]) > Nice fix! Thanks. Comment on attachment 230447 [details] Patch Clearing flags on attachment: 230447 Committed r167976: <http://trac.webkit.org/changeset/167976> All reviewed patches have been landed. Closing bug. |
Created attachment 230282 [details] 'File name too long' error example Whilst trying to build the WebKit GTK version using the command: ./Tools/Scripts/build-webkit --gtk I am encountering a 'File name too long' error in multiple places (please see attachment for example of error output). As far as I know the WebKit GTK buildbot builds do not seem to be having this problem. Some details of my machine configuration: Architecture: x86_64 Linux Distribution: Ubuntu 12.04 GCC/G++ version: 4.8 CMake version: 2.8.7