Bug 132223

Summary: [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Create m_bundleParameters if needed sam: review+

mitz
Reported 2014-04-26 18:53:28 PDT
[Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet
Attachments
Create m_bundleParameters if needed (1.52 KB, patch)
2014-04-26 18:54 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-04-26 18:54:57 PDT
Created attachment 230249 [details] Create m_bundleParameters if needed
Sam Weinig
Comment 2 2014-04-27 15:45:48 PDT
Comment on attachment 230249 [details] Create m_bundleParameters if needed View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review > Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137 > + m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]); Maybe @{ } instead of [NSDictionary dictionary]?
mitz
Comment 3 2014-04-27 16:13:50 PDT
(In reply to comment #2) > (From update of attachment 230249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137 > > + m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]); > > Maybe @{ } instead of [NSDictionary dictionary]? Done. Fixed in <http://trac.webkit.org/r167865>.
Note You need to log in before you can comment on or make changes to this bug.