Summary: | ScrollingCoordinator is unaware of topContentInset | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | andersca, bdakin, bfulgham, cmarcelo, commit-queue, darin, jamesr, luiz, thorton, tonikitoo | ||||
Priority: | P1 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-04-24 17:29:15 PDT
Created attachment 230126 [details]
Patch
Comment on attachment 230126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230126&action=review > LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test.html:52 > + //debug("Page before: " + pageScrollPositionBefore + ", select before: " + selectScrollPositionBefore); > + //debug("Page after: " + pageScrollPositionAfter + ", select after: " + selectScrollPositionAfter); ??? Comment on attachment 230126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230126&action=review >> LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test.html:52 >> + //debug("Page after: " + pageScrollPositionAfter + ", select after: " + selectScrollPositionAfter); > > ??? WK1 and WK2 sometimes produce different values here. Rather than baseline both, we comment these out. It's useful to uncommercial them while debugging. (In reply to comment #4) > (From update of attachment 230126 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230126&action=review > > >> LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test.html:52 > >> + //debug("Page after: " + pageScrollPositionAfter + ", select after: " + selectScrollPositionAfter); > > > > ??? > > WK1 and WK2 sometimes produce different values here. Rather than baseline both, we comment these out. It's useful to uncommercial them while debugging. And by uncommercial, I of course mean uncomment them. Comment on attachment 230126 [details] Patch Clearing flags on attachment: 230126 Committed r167807: <http://trac.webkit.org/changeset/167807> All reviewed patches have been landed. Closing bug. |