Bug 132149

Summary:

Web Inspector: CodeMirror 4 CSS mode new state data structure breaks helpers.

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions.	none

Description Jonathan Wells 2014-04-24 15:20:11 PDT

CSS mode has done away with state.stack to track the mode hierarchy and instead uses a linked object structure. Pretty Printing and other CodeMirror helpers/addons are broken as a result and need to be updated for the new structure.

Comment 1 Radar WebKit Bug Importer 2014-04-24 15:21:06 PDT

<rdar://problem/16718309>

Comment 2 Jonathan Wells 2014-05-01 19:31:00 PDT

Created attachment 230645 [details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions.

Carefully went through and changed references to tokens and states appropriately.

Comment 3 Timothy Hatcher 2014-05-01 19:53:05 PDT

Looks good to me. I'd like Joe to take a look too.

Comment 4 Joseph Pecoraro 2014-05-02 08:33:33 PDT

Comment on attachment 230645 [details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions.

Looks good to me

Comment 5 WebKit Commit Bot 2014-05-02 09:04:38 PDT

Comment on attachment 230645 [details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions.

Clearing flags on attachment: 230645

Committed r168170: <http://trac.webkit.org/changeset/168170>

Comment 6 WebKit Commit Bot 2014-05-02 09:04:41 PDT

All reviewed patches have been landed.  Closing bug.