Summary: | Crash in platform/mac/accessibility/table-visible-rows.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
Component: | Tools / Tests | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, mark.lam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mark Lam
2014-04-24 15:03:30 PDT
Created attachment 230192 [details]
Patch
Comment on attachment 230192 [details]
Patch
r=me. But can you do a quick grep for JSObjectMakeArray to see if anyone in our system is doing the wrong thing, but happens to be uncaught by tests?
(In reply to comment #3) > (From update of attachment 230192 [details]) > r=me. But can you do a quick grep for JSObjectMakeArray to see if anyone in our system is doing the wrong thing, but happens to be uncaught by tests? I already did and the patch contains the other instances. Committed r167819: <http://trac.webkit.org/changeset/167819> Comment on attachment 230192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230192&action=review > Tools/DumpRenderTree/AccessibilityUIElement.cpp:522 > - auto valueElements = std::make_unique<JSValueRef[]>(elementCount); > + JSValueRef valueElements[elementCount]; It broke the Apple Windows build: 1>..\..\AccessibilityUIElement.cpp(522): error C2057: expected constant expression 1>..\..\AccessibilityUIElement.cpp(522): error C2466: cannot allocate an array of constant size 0 1>..\..\AccessibilityUIElement.cpp(522): error C2133: 'valueElements' : unknown size Unfortunately you weren't able to catch this build failure, because others broke the Windows build previously and didn't care about the buildfix at all. Unfortunately, Visual Studio isn't smart about this logic: size_t elementCount = elements.size(); JSValueRef valueElements[elementCount]; ... giving the following errors: AccessibilityUIElement.cpp TestRunner.cpp 1>..\..\AccessibilityUIElement.cpp(522): error C2057: expected constant expression 1>..\..\AccessibilityUIElement.cpp(522): error C2466: cannot allocate an array of constant size 0 1>..\..\AccessibilityUIElement.cpp(522): error C2133: 'valueElements' : unknown size 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-debug\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj" (Build target(s)) -- FAILED. Will post an updated fix that should work for windows. Created attachment 230336 [details]
Updated patch with speculative Windows fix
Committed r167913: <http://trac.webkit.org/changeset/167913> |