Bug 132136

Summary: [iOS WebKit2] Should properly handle focus redirect (keyboard state changes when focus changes)
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch2 benjamin: review+

Enrica Casucci
Reported 2014-04-24 11:24:28 PDT
In pages where fields are focused from Javascript we should not display the keyboard, unless the user has already started interacting with the page. <rdar://problem/16238336>
Attachments
Patch (4.62 KB, patch)
2014-04-24 11:32 PDT, Enrica Casucci 		no flags
DetailsFormatted DiffDiff
Patch2 (13.03 KB, patch)
2014-04-24 14:29 PDT, Enrica Casucci 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-04-24 11:32:23 PDT
Created attachment 230095 [details] Patch
Benjamin Poulain
Comment 2 2014-04-24 12:42:30 PDT
Comment on attachment 230095 [details] Patch To be udpated.
Enrica Casucci
Comment 3 2014-04-24 14:29:40 PDT
Created attachment 230106 [details] Patch2 After discussing the first patch with Ben, I've implemented a different solution.
Benjamin Poulain
Comment 4 2014-04-24 14:34:08 PDT
Comment on attachment 230106 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=230106&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:317 > + RefPtr<Frame> oldFocusedFrame = m_page->focusController().focusedFrame(); > + RefPtr<Element> oldFocusedElement = oldFocusedFrame ? oldFocusedFrame->document()->focusedElement() : nullptr; > + m_userIsInteracting = true; I believe you will need the same logic in WebPage::dispatchTouchEvent().
Enrica Casucci
Comment 5 2014-04-24 14:45:23 PDT
Committed revision 167774.
Note You need to log in before you can comment on or make changes to this bug.