Summary: | [iOS WebKit2] Should properly handle focus redirect (keyboard state changes when focus changes) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||
Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | InRadar | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Enrica Casucci
2014-04-24 11:24:28 PDT
Created attachment 230095 [details]
Patch
Comment on attachment 230095 [details]
Patch
To be udpated.
Created attachment 230106 [details]
Patch2
After discussing the first patch with Ben, I've implemented a different solution.
Comment on attachment 230106 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=230106&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:317 > + RefPtr<Frame> oldFocusedFrame = m_page->focusController().focusedFrame(); > + RefPtr<Element> oldFocusedElement = oldFocusedFrame ? oldFocusedFrame->document()->focusedElement() : nullptr; > + m_userIsInteracting = true; I believe you will need the same logic in WebPage::dispatchTouchEvent(). Committed revision 167774. |