Summary: | Web Inspector: Selecting frame in debugger sidebar doesn't reveal code | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
URL: | http://graougraou.com/tests/inspector-debugger/debug.html | ||||||||||||
Attachments: |
|
Description
Antoine Quint
2014-04-24 01:02:55 PDT
Created attachment 230061 [details] Behaviour in WebKit nightly r167733 Dupe of <rdar://problem/16491500>. Created attachment 231026 [details]
[PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter
Comment on attachment 231026 [details] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter View in context: https://bugs.webkit.org/attachment.cgi?id=231026&action=review This seems good to me, since we shouldn't assume that the navigation sidebar has only one outline (or that its selection is within the content outline). I think you need to rebase the patch. > Source/WebInspectorUI/UserInterface/Base/Main.js:-1838 > - Are you adding or removing trailing whitespace here? Comment on attachment 231026 [details] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter View in context: https://bugs.webkit.org/attachment.cgi?id=231026&action=review r=me with some comments > Source/WebInspectorUI/ChangeLog:8 > + `WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar` was checking No need for all the backticks here. > Source/WebInspectorUI/UserInterface/Base/Main.js:925 > + if (!selectedSidebarPanel.elementIsSelected) I think the name "elementIsSelected" is weird. Maybe "hasSelectedElement" or "hasSelection"? > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:132 > + get elementIsSelected() { Style: Brace on newline. Created attachment 231085 [details]
[PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter REV 1
Comment on attachment 231085 [details]
[PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter REV 1
r=me
Comment on attachment 231085 [details] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter REV 1 Clearing flags on attachment: 231085 Committed r168484: <http://trac.webkit.org/changeset/168484> All reviewed patches have been landed. Closing bug. Comment on attachment 231085 [details] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter REV 1 View in context: https://bugs.webkit.org/attachment.cgi?id=231085&action=review > Source/WebInspectorUI/ChangeLog:10 > + base getter elementIsSelected to NavigationSidebarPanel and extended it in "getter" should be "function" with the change below. > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:135 > + get hasSelectedElement() > + { > + return !!this._breakpointsContentTreeOutline.selectedTreeElement || !!this._callStackContentTreeOutline.selectedTreeElement; > + }, We don't use verb prefixes with getters. This should be a plain function. > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:150 > + get hasSelectedElement() Ditto. |