Bug 132083

Summary: Web Inspector: gradient editor does not appear for linear-gradient with no specified angle
Product: WebKit Reporter: Bear Travis <betravis>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Reduced testcase.
none
Patch none

Bear Travis
Reported 2014-04-23 15:20:58 PDT
Some gradients do not appear to trigger the new gradient editor. I used styles.css: .float { background: linear-gradient(green, blue); } and test.html: <!doctype html> <html> <head> <link href='styles.css' rel='stylesheet'> <style> .float { width: 200px; height: 200px; float: left; } </style> </head> <body> <div class='float'></div> </div> </body> </html> Changing the gradient to linear-gradient(0deg, green, blue) did work.
Attachments
Reduced testcase. (83 bytes, text/html)
2014-04-24 01:05 PDT, Antoine Quint 		no flags
Details
Patch (1.68 KB, patch)
2014-04-24 01:57 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-23 15:21:31 PDT
<rdar://problem/16705257>
Antoine Quint
Comment 2 2014-04-24 01:05:20 PDT
Created attachment 230062 [details] Reduced testcase.
Antoine Quint
Comment 3 2014-04-24 01:43:48 PDT
WebInspector.LinearGradient.linearGradientWithComponents() is being called with components = [["green"], ["blue"]] and hits the following branch: // We don't support any of the legacy linear gradient formats. return null; … which was added in http://trac.webkit.org/changeset/165017 to fix https://bugs.webkit.org/show_bug.cgi?id=129623.
Antoine Quint
Comment 4 2014-04-24 01:57:31 PDT
Created attachment 230065 [details] Patch
WebKit Commit Bot
Comment 5 2014-04-24 07:37:46 PDT
Comment on attachment 230065 [details] Patch Clearing flags on attachment: 230065 Committed r167756: <http://trac.webkit.org/changeset/167756>
WebKit Commit Bot
Comment 6 2014-04-24 07:37:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.