Bug 132082

Summary:

Mock scrollbars don't always work in DumpRenderTree

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Tools / Tests

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, hyatt, jonlee, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ap: review+

Description Tim Horton 2014-04-23 15:00:55 PDT

The mock scrollbar Setting is set after view creation in DRT. If any scrollbars are created during view creation and do not get replaced later, they will be platform scrollbars instead of mock scrollbars (because setting the setting doesn't force the scrollbars to be recreated). WebKitTestRunner gets around this by setting the preference before creating the view; doing so in DRT as well makes everything happy.

Comment 1 Tim Horton 2014-04-23 15:03:36 PDT

Created attachment 230013 [details]
patch

Comment 2 Tim Horton 2014-04-23 15:05:00 PDT

At some point we should probably fix the FIXME in Settings::setMockScrollbarsEnabled, but that is harder.

Comment 3 Alexey Proskuryakov 2014-04-23 15:16:41 PDT

Should we remove that from resetWebPreferencesToConsistentValues()? Can tests change the value of this preference at all?

Comment 4 Tim Horton 2014-04-23 15:21:35 PDT

(In reply to comment #3)
> Should we remove that from resetWebPreferencesToConsistentValues()? Can tests change the value of this preference at all?

Since it's a WebCore setting and exposed via internals, they CAN, but shouldn't, and the only tests that set it set it to true (why‽).

Comment 5 Tim Horton 2014-04-23 15:23:55 PDT

http://trac.webkit.org/changeset/167728

Comment 6 Alexey Proskuryakov 2014-04-23 15:50:58 PDT

Filed bug 132085 to kill it.

Comment 7 Radar WebKit Bug Importer 2014-04-23 20:01:22 PDT

<rdar://problem/16708329>