Bug 13208

Summary:

There should be a way to break long words in tables

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, mitz

Priority:

Keywords:

HasReduction, InRadar

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Resize window to see the bug	none
Another test	none
Same as previous test but with word-break: break-all added	none
First cut at break-all support.	none
white-space:pre doesn't work with word-break:break-all (unlike word-wrap: break-word)	none
Patch to implement word-break partially (we don't support keep-all).	bdakin: review+

Beth Dakin

Reported 2007-03-27 14:44:43 PDT

* SUMMARY If you have a line of text with the word-break property set to break-all, long words do not wrap if the text is located within a table. * STEPS TO REPRODUCE 1. See attached text file for example. * RESULTS The first line of text in the sample is in a span and forcibly wraps (correctly) when you resize the window. The second line of text is in a table with a width of 100% and does not wrap.

Attachments
Resize window to see the bug (505 bytes, text/html) 2007-03-27 14:45 PDT, Beth Dakin	no flags	Details
Another test (167 bytes, text/html) 2007-03-29 15:36 PDT, Dave Hyatt	no flags	Details
Same as previous test but with word-break: break-all added (190 bytes, text/html) 2007-03-29 15:44 PDT, Dave Hyatt	no flags	Details
First cut at break-all support. (13.17 KB, patch) 2007-04-19 01:54 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
white-space:pre doesn't work with word-break:break-all (unlike word-wrap: break-word) (13.11 KB, patch) 2007-04-19 02:17 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch to implement word-break partially (we don't support keep-all). (115.19 KB, patch) 2007-04-19 17:29 PDT, Dave Hyatt	bdakin: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2007-03-27 14:45:46 PDT

Created attachment 13833 [details] Resize window to see the bug

Beth Dakin

Comment 2 2007-03-27 14:46:32 PDT

<rdar://problem/4881048>

mitz

Comment 3 2007-03-28 01:29:11 PDT

Bug 13213 sounds like it might be in the same area (assuming the area turns out to be "min intrinsic width calculation for table cells").

Dave Hyatt

Comment 4 2007-03-29 15:27:30 PDT

This behavior was deliberate. I tested in WinIE when I implemented word-wrap: break-word, and they don't compute minimum width for table cells taking word-wrap:break-word into account. If they did, there would be all sorts of table constructs that would result in cells with one character per line.

Dave Hyatt

Comment 5 2007-03-29 15:33:32 PDT

This test case works in IE7 though. My suspicion is that there may be two kinds of min width unfortunately. Once the containing block puts you under pressure, you shrink further.

Dave Hyatt

Comment 6 2007-03-29 15:36:46 PDT

Created attachment 13881 [details] Another test

Dave Hyatt

Comment 7 2007-03-29 15:39:46 PDT

The second test shows the problem. IE7 ignores word-wrap:break-word on it.

Dave Hyatt

Comment 8 2007-03-29 15:43:24 PDT

I just noticed the first case also uses a property called "word-break." We do not support that property, and it could be why the first case is working.

Dave Hyatt

Comment 9 2007-03-29 15:44:34 PDT

Created attachment 13882 [details] Same as previous test but with word-break: break-all added

Dave Hyatt

Comment 10 2007-04-05 11:41:57 PDT

word-break does not appear to be relevant here.

Dave Hyatt

Comment 11 2007-04-19 00:22:15 PDT

I am wrong about this. word-break: break-all is key. word-wrap is completely irrelevant. Testing with IE7, word-break:break-all causes the cell to actually wrap under pressure.

Dave Hyatt

Comment 12 2007-04-19 00:39:38 PDT

Raising to p1 to match internal bug status.

mitz

Comment 13 2007-04-19 01:26:32 PDT

(In reply to comment #11) > Testing with IE7, word-break:break-all causes the cell to actually > wrap under pressure. Is this an IE7 only thing? With IE6 I don't see any difference between attachment 13881 [details] and attachment 13882 [details].

Dave Hyatt

Comment 14 2007-04-19 01:54:17 PDT

Created attachment 14085 [details] First cut at break-all support. Not for review yet. Just getting a patch up to track progress.

Dave Hyatt

Comment 15 2007-04-19 01:56:50 PDT

There's a typo in the tests, which is what caused all the confusion in the first place. Marking them as obsolete to avoid confusion.

Dave Hyatt

Comment 16 2007-04-19 02:17:06 PDT

Created attachment 14086 [details] white-space:pre doesn't work with word-break:break-all (unlike word-wrap: break-word) Don't look at me. I didn't design this crazy shit (shakes fist at Microsoft).

Dave Hyatt

Comment 17 2007-04-19 17:29:24 PDT

Created attachment 14100 [details] Patch to implement word-break partially (we don't support keep-all).

Beth Dakin

Comment 18 2007-04-19 17:39:35 PDT

Comment on attachment 14100 [details] Patch to implement word-break partially (we don't support keep-all). r=me!

Dave Hyatt

Comment 19 2007-04-19 22:22:01 PDT

r20967.

Note You need to log in before you can comment on or make changes to this bug.