Bug 132051

Summary:

[GTK] run-webkit-tests script is failing to invoke run-launcher

Product:

WebKit

Reporter:

Lorenzo Tilve <ltilve>

Component:

WebKitGTK

Assignee:

Lorenzo Tilve <ltilve>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, glenn, jhoneycutt, mrobinson, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Lorenzo Tilve

Reported 2014-04-23 01:45:57 PDT

When manually running a test like: Tools/Scripts/run-webkit-tests --gtk webaudio/codec-tests/mp3/128kbps-44khz.html As the --no-show-results parameter is not used, if there is some failing test, run-launcher is invoked to show the diffs, but this call seems to be failing due to be receiving a -2 parameter that is not longer supported. 0 tests ran as expected, 1 didn't: ScriptError raised: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/ltilve/WebKit/WebKitBuild/Release/layout-test-results/results.html', '-2']" exit_code: 1 cwd: /home/ltilve/WebKit Traceback (most recent call last): File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 80, in main run_details = run(port, options, args, stderr) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 401, in run run_details = manager.run(args) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 242, in run self._port.show_results_html_file(results_path) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 191, in show_results_html_file self._run_script("run-launcher", run_launcher_args) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1283, in _run_script output = self._executive.run_command(run_script_command, cwd=self.webkit_base(), decode_output=decode_output, env=env) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 452, in run_command (error_handler or self.default_error_handler)(script_error) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 370, in default_error_handler raise error ScriptError: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/ltilve/WebKit/WebKitBuild/Release/layout-test-results/results.html', '-2']" exit_code: 1 cwd: /home/ltilve/WebKit

Attachments
Patch (1.69 KB, patch) 2014-04-23 02:00 PDT, Lorenzo Tilve	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lorenzo Tilve

Comment 1 2014-04-23 02:00:27 PDT

Created attachment 229966 [details] Patch

WebKit Commit Bot

Comment 2 2014-04-23 02:40:18 PDT

Comment on attachment 229966 [details] Patch Clearing flags on attachment: 229966 Committed r167702: <http://trac.webkit.org/changeset/167702>

WebKit Commit Bot

Comment 3 2014-04-23 02:40:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.