Bug 132038 – Cursor doesn't change back to pointer when leaving Mail

• Component: UI Events
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Reproduction steps:
1. Visit simple-rte.rniwa.com
2. Focus the textarea in the bottom. Observe that the cursor is now I-beam.
3. Move the cursor towards the right edge of the Safari window (but keep it inside the window).
4. Rapidly move the mouse cursor out of the window.

Expected result:
The cursor changes to pointer

Actual result:
The cursor remains I-beam.

<rdar://problem/15345851>

[Ryosuke Niwa]

This bug is partially caused by http://trac.webkit.org/changeset/147739.

[Ryosuke Niwa]

Created attachment 229955 [details]
Fixes the bug

[Alexey Proskuryakov]

Comment on attachment 229955 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=229955&action=review

> Source/WebCore/page/EventHandler.cpp:1386
> +        bool editable = node ? node->hasEditableStyle() : false;

I think that "node && node->hasEditableStyle()" would be more readable than a ternary.

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 229955 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229955&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:1386
> > +        bool editable = node ? node->hasEditableStyle() : false;
> 
> I think that "node && node->hasEditableStyle()" would be more readable than a ternary.

Will fix. Thanks for the review!

[Ryosuke Niwa]

Created attachment 229957 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 229957 [details]
Patch for landing

Clearing flags on attachment: 229957

Committed r167700: <http://trac.webkit.org/changeset/167700>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 229955 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=229955&action=review

> Source/WebKit/mac/ChangeLog:14
> +        Instead, check whether the NSWindow of the WebView is the key window or not since
> +        key window appears to control the cursor style in Cocoa as far as I've tested:
> +        https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html

Did you retest the problems described in <rdar://problem/14619911> to see if it’s still fixed?

[WebKit Commit Bot]

Re-opened since this is blocked by bug 132142

[Ryosuke Niwa]

Created attachment 249459 [details]
Fixes the bug

[Ryosuke Niwa]

Created attachment 249508 [details]
Patch

[Ryosuke Niwa]

Created attachment 249509 [details]
Fixed change logs

[Ryosuke Niwa]

Created attachment 249513 [details]
Reverted the refactroing per Andres' request

[Ryosuke Niwa]

Committed r182026: <http://trac.webkit.org/changeset/182026>